-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom VariantClassification
severity ordering.
#7673
Conversation
@xaviloinaz here's that feature you requested for configurable ordering of funotations via Let me know if this won't work for what you wanted to do. |
4a10f74
to
c44e964
Compare
c44e964
to
b9df7c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonn-smith Back to you with my comments
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorArgumentDefinitions.java
Outdated
Show resolved
Hide resolved
...in/java/org/broadinstitute/hellbender/tools/funcotator/BaseFuncotatorArgumentCollection.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtils.java
Outdated
Show resolved
Hide resolved
...a/org/broadinstitute/hellbender/tools/funcotator/dataSources/gencode/GencodeFuncotation.java
Show resolved
Hide resolved
src/test/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtilsUnitTest.java
Show resolved
Hide resolved
src/test/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorUtilsUnitTest.java
Outdated
Show resolved
Hide resolved
...oadinstitute/hellbender/tools/funcotator/dataSources/gencode/GencodeFuncotationUnitTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 merge when tests pass @jonn-smith
VariantClassification
severity ordering. This enables users to have variants annotated consistently in an alternate order by the results of their variant classification. (user requested)